DHCP_am: support multiple nameservers#4834
Merged
gpotter2 merged 2 commits intosecdev:masterfrom Sep 15, 2025
gpotter2:nameservers
Merged
DHCP_am: support multiple nameservers#4834gpotter2 merged 2 commits intosecdev:masterfrom gpotter2:nameservers
gpotter2 merged 2 commits intosecdev:masterfrom
gpotter2:nameservers
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4834 +/- ##
==========================================
- Coverage 80.88% 80.50% -0.38%
==========================================
Files 368 368
Lines 90231 90236 +5
==========================================
- Hits 72980 72643 -337
- Misses 17251 17593 +342
🚀 New features to boost your workflow:
|
evverx
reviewed
Sep 18, 2025
| result | ||
|
|
||
| # 3 results depending on the Python version | ||
| assert result in [ |
Contributor
There was a problem hiding this comment.
Looks like it fails on Fedora Rawhide (with Python 3.14.0rc2):
###(006)=[failed] Check that the dhcpd alias is properly defined and documented
>>> assert dhcpd
>>> import IPython
>>>
>>> result = IPython.lib.pretty.pretty(dhcpd)
>>> result
'<function scapy.ansmachine.dhcpd(self, pool: scapy.base_classes.Net | List[str] = Net("192.168.1.128/25"), network: str = \'192.168.1.0/24\', gw: str = \'192.168.1.1\', nameserver: str | List[str] = None, domain: str | None = None, renewal_time: int = 60, lease_time: int = 1800, **kwargs)>'
>>>
>>> assert result in [
... '<function scapy.ansmachine.dhcpd(self, pool: Union[scapy.base_classes.Net, List[str]] = Net("192.168.1.128/25"), network: str = \'192.168.1.0/24\', gw: str = \'192.168.1.1\', nameserver: Union[str, List[str]] = None, domain: Optional[str] = None, renewal_time: int = 60, lease_time: int = 1800, **kwargs)>',
... '<function scapy.ansmachine.dhcpd(self, pool: Union[scapy.base_classes.Net, List[str]] = Net("192.168.1.128/25"), network: str = \'192.168.1.0/24\', gw: str = \'192.168.1.1\', nameserver: Union[str, List[str]] = None, domain: Union[str, NoneType] = None, renewal_time: int = 60, lease_time: int = 1800, **kwargs)>',
... '<function scapy.ansmachine.dhcpd(self, pool=Net("192.168.1.128/25"), network=\'192.168.1.0/24\', gw=\'192.168.1.1\', nameserver=None, domain=None, renewal_time=60, lease_time=1800, **kwargs)>',
... ]
AssertionError
Member
Author
There was a problem hiding this comment.
Thanks ! See befe516
This varies a LOT depending on the Python version hehe ^^
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #4638
fixes #4431